Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review unnecessary GoldActuator state assignment #88

Open
alex-brinkman opened this issue Apr 3, 2023 · 0 comments
Open

Review unnecessary GoldActuator state assignment #88

alex-brinkman opened this issue Apr 3, 2023 · 0 comments
Assignees

Comments

@alex-brinkman
Copy link
Collaborator

alex-brinkman commented Apr 3, 2023

I do not think the below assignments are necessary. When the Fastcat manager calls its Process function, the state from the underlying JSD device will be read first, so jsd_egd_state_ will end up with the values assigned in jsd_egd_fault.

Only way this could not be the case would be if the JSD driver changed its rxpdo between the call to jsd_egd_fault and the call to Actuator::Read(), and that is not possible because the writing and processing functions of the JSD driver are called AFTER the Fastcat manager reads states.

I will not remove them with my changes, but I think we should in the upcoming PRs.

Originally posted by @d-loret in #86 (comment)

@alex-brinkman alex-brinkman changed the title I do not think the below assignments are necessary. When the Fastcat manager calls its Process function, the state from the underlying JSD device will be read first, so jsd_egd_state_ will end up with the values assigned in jsd_egd_fault. Review unnecessary GoldActuator state assignment Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants