fixed goroutine leak

lumberjack.go

@@ -112,6 +112,7 @@ type Logger struct {
 	mu   sync.Mutex
 
 	millCh    chan bool
+	wg        sync.WaitGroup
 	startMill sync.Once
 }
 
@@ -165,7 +166,15 @@ func (l *Logger) Write(p []byte) (n int, err error) {
 func (l *Logger) Close() error {
 	l.mu.Lock()
 	defer l.mu.Unlock()
-	return l.close()
+
+	err := l.close()
+
+	if l.millCh != nil {
+		close(l.millCh)
+		l.wg.Wait()
+	}
+	return err
+
 }
 
 // close closes the file if it is open.
@@ -376,6 +385,7 @@ func (l *Logger) millRunOnce() error {
 // millRun runs in a goroutine to manage post-rotation compression and removal
 // of old log files.
 func (l *Logger) millRun() {
+	defer l.wg.Done()
 	for _ = range l.millCh {
 		// what am I going to do, log this?
 		_ = l.millRunOnce()
@@ -386,6 +396,7 @@ func (l *Logger) millRun() {
 // starting the mill goroutine if necessary.
 func (l *Logger) mill() {
 	l.startMill.Do(func() {
+		l.wg.Add(1)
 		l.millCh = make(chan bool, 1)
 		go l.millRun()
 	})

lumberjack_test.go

@@ -623,7 +623,7 @@ func TestCompressOnRotate(t *testing.T) {
 
 	// we need to wait a little bit since the files get compressed on a different
 	// goroutine.
-	<-time.After(10 * time.Millisecond)
+	<-time.After(20 * time.Millisecond)
 
 	// a compressed version of the log file should now exist and the original
 	// should have been removed.
@@ -672,7 +672,7 @@ func TestCompressOnResume(t *testing.T) {
 
 	// we need to wait a little bit since the files get compressed on a different
 	// goroutine.
-	<-time.After(10 * time.Millisecond)
+	<-time.After(20 * time.Millisecond)
 
 	// The write should have started the compression - a compressed version of
 	// the log file should now exist and the original should have been removed.