Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Reconnect #906

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Implement Reconnect #906

merged 2 commits into from
Jul 3, 2024

Conversation

scottf
Copy link
Collaborator

@scottf scottf commented Jul 3, 2024

@scottf scottf requested a review from mtmk July 3, 2024 19:23
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after considering documentation suggestion

public sealed class ReconnectOptions
{
private int flushTimeout = 0;
public int FlushTimeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document unit (seconds, ms)

}

/// <summary>
///
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing doc

@scottf scottf merged commit 0633fb9 into main Jul 3, 2024
1 check passed
@scottf scottf deleted the reconnect branch July 3, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants