Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST-151: add code for integration #8

Merged
merged 20 commits into from
Apr 4, 2024
Merged

Conversation

ccheng26
Copy link
Collaborator

@ccheng26 ccheng26 commented Apr 3, 2024

Ensure mistral-7b-instruct-v0.1.Q4_0.gguf is downloaded and in models/

Run instructions

Start the chatbot service: `./chainlit-household-bot.py` or `chainlit run chainlit-household-bot.py`

Click on Settings > Choose embedding/llm > Enable Use vector db sources

Click on upload query
Add guru_card json file
Ask query after processing time

Copy link
Collaborator

@yoomlam yoomlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preliminary review

02-household-queries/.gitignore Outdated Show resolved Hide resolved
02-household-queries/chainlit-household-bot.py Outdated Show resolved Hide resolved
02-household-queries/chainlit-household-bot.py Outdated Show resolved Hide resolved
02-household-queries/chainlit-household-bot.py Outdated Show resolved Hide resolved
02-household-queries/chainlit-household-bot.py Outdated Show resolved Hide resolved
@ccheng26 ccheng26 requested a review from yoomlam April 3, 2024 17:14
@ccheng26
Copy link
Collaborator Author

ccheng26 commented Apr 3, 2024

GPT4All issues will be addressed in https://navalabs.atlassian.net/browse/DST-152

@ccheng26 ccheng26 requested a review from yoomlam April 3, 2024 20:40
@ccheng26 ccheng26 marked this pull request as ready for review April 3, 2024 20:40
@yoomlam
Copy link
Collaborator

yoomlam commented Apr 3, 2024

Bug: A chroma folder is being created, in addition to chroma_db.

To replicate:

  1. Quit Chainlit
  2. Delete folders
rm -rf chroma chroma_db
  1. Then start Chainlit
  2. Note the chroma folder was created

@ccheng26
Copy link
Collaborator Author

ccheng26 commented Apr 3, 2024

Bug: A chroma folder is being created, in addition to chroma_db.

To replicate: Stop Chainlit

rm -rf chroma chroma_db

Then start Chainlit

This is due to the use of chroma.PersistentClient, the folder is for the instance of chroma, not the db itself. To reset the db we need to call the chromadb package directly for the reset option, this option isn't available for the package in langchain_community.vectorstores

@ccheng26 ccheng26 requested a review from yoomlam April 3, 2024 21:03
@ccheng26 ccheng26 requested a review from yoomlam April 4, 2024 00:29
Copy link
Collaborator

@yoomlam yoomlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, after making suggested changes.

02-household-queries/.gitignore Outdated Show resolved Hide resolved
02-household-queries/retrieval.py Outdated Show resolved Hide resolved
@ccheng26 ccheng26 merged commit 7284f1f into main Apr 4, 2024
2 checks passed
@ccheng26 ccheng26 deleted the DST-151-chainlitIntegration branch April 4, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants