-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building for TV Devices #1566
Open
dev-seb
wants to merge
9
commits into
necolas:master
Choose a base branch
from
dev-seb:feature/tv-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Building for TV Devices #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for : - TVEventHandler events - Platform.isTV - hasTVPreferredFocus property - nextFocusUp, nextFocusRight, nextFocusDown, nextFocusLeft properties - back event from remote control
…to feature/tv-support
- Enable TV support on TouchableHighlight only and if Platform.isTV is true - Move Key Event handler to useTVEvents module - Support both NodeHandle and nativeID for nextFocus props
dev-seb
force-pushed
the
feature/tv-support
branch
from
January 27, 2021 13:38
d516c5c
to
b4a82ca
Compare
Hello, possible to solve those conflicts @dev-seb ? thx |
It should be solved with 549ec21 |
@necolas What became of this PR? This is really needed |
Is there any way to help merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for TV Devices:
Demo app : https://github.com/dev-seb/react-native-tv-demo
The expected behaviour is the same as for AndroidTV and tvOS, and only if Platform.isTV property is true.
For Platform.isTV is should be possible to parse the User Agent, but env variable seems more suitable to specify whether or not the current app is targeting TVs.
For spatial navigation, the demo relies for web on the third party library Spatial Navigation Polyfill.