Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code in the Reloading module #1268

Open
wants to merge 1 commit into
base: 7.1.x
Choose a base branch
from

Conversation

cheerfulstoic
Copy link
Contributor

This is an attempt to fix the issue where CypherNode objects cease to be wrapped anymore until the Ruby process (server, background workers, whatever) process is restarted.

@subvertallchris I ripped out some of this and so I'm somewhat worried that I've broken something, but it seems to work locally on my app. Curious for your feedback

@subvertallchris
Copy link
Contributor

The lines you pulled out aim to do exactly what you're having trouble with. This PR has some notes that are familiar but I can't remember who was seeing this or how to reproduce. I guess I don't have better tests in there because the reloader makes the difficult, wish I had included more notes. :-(

If I had to guess, maybe a reload of the app followed by a query that returns nodes without loaded models would return CypherNode? That doesn't really make sense to me since t should just follow the process that occurs when the app is first started. It should look at the labels and try to find the class. I'm not entirely sure... Maybe sneak it into the alpha and we'll test it along with everything else?

@cheerfulstoic
Copy link
Contributor Author

👍, thanks ;)

@cheerfulstoic
Copy link
Contributor Author

(We've been using this branch at work for a while now and I don't think we've seen the CypherNode error or any other loading issues. We'll see how it goes in 8.0 alpha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants