Fix writing ELF section for sbf targets #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solana toolchain has completely switched away from the BPF target in favor of SBF. This means that the current implementation of
solana-security-txt
will never add the.security.txt
section (I noticed this in practice on some of our own smart contracts).This PR fixes this. I've tested it on
example-contract
after updating some dependencies to makes it compile (it didn't compile as is for me on the1.18.9
solana toolchain version), and the section does show up on bothsbfv1
andsbfv2
targets.