Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

66 scotland features #70

Draft
wants to merge 15 commits into
base: dev
Choose a base branch
from
Draft

66 scotland features #70

wants to merge 15 commits into from

Commits on Sep 25, 2024

  1. simplify listed buildings functions

    @crispy-wonton
    crispy-wonton committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3093f89 View commit details
    Browse the repository at this point in the history

  2. add Scotland listed buildings dataset to config yaml

    @crispy-wonton
    crispy-wonton committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2c7ae30 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. update config base.yaml data source for Scotland listed buildings to … 

    …use points instead of boundaries.

this is due to boundaries dataset not being complete
    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6f9f289 View commit details
    Browse the repository at this point in the history

  2. update listed buildings getter to load Scotland data optionally in ge… 

    …t_datasets.py
    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b77104e View commit details
    Browse the repository at this point in the history

  3. update listed_buildings.py functions to transform Scotland data as we… 

    …ll as England and Wales

- fix bug in Wales data processing. Wales listed buildings dataset is shared as point geometries, not polygons so update from sjoin to sjoin_nearest
- refactor the EPC chunking function slightly to be more succinct
    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0f0be13 View commit details
    Browse the repository at this point in the history

  4. fix small bug introduced in listed_buildings.py - delete unused `nati… 

    …on` param
    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    08324fc View commit details
    Browse the repository at this point in the history

  5. add notebook to explore listed building data in Scotland and determin… 

    …e nearest neighbour distance threshold
    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    eca12df View commit details
    Browse the repository at this point in the history

  6. fix usecols bug in listed_buildings.py

    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    80ce9f8 View commit details
    Browse the repository at this point in the history

  7. fix minor bug introduced in listed_buildings.py

    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    072c2b0 View commit details
    Browse the repository at this point in the history

  8. left join listed buildings to EPC instead of inner join in listed_bui… 

    …ldings.py
    @crispy-wonton
    crispy-wonton committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6e9c38b View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. add world heritage sites flag for scotland 

    - add WHS dataset to config base.yaml
- rename conservation_areas.py to protected_areas.py
- add functions to protected_areas.py to transform WHS data
- update cons area functions in protected_areas.py to return properties in cons areas only
- update listed_buildings.py functions to return properties in listed buildings only
- update geospatial functions that join data to EPC to use epc geodataframe where possible instead of generating new gdf every time - changes to listed_buildings.py; output_areas.py; protected_areas.py
- update run_add_features.py script to use new WHS functions and to use EPC gdf instead of EPC df
    @crispy-wonton
    crispy-wonton committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6bb7d83 View commit details
    Browse the repository at this point in the history

  2. add new run script to download INSPIRE files for Scotland to S3 

    - add INSPIRE scotland data source to S3
    @crispy-wonton
    crispy-wonton committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    27a7cff View commit details
    Browse the repository at this point in the history

  3. populate script to download INSPIRE files for Scotland

    @crispy-wonton
    crispy-wonton committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2b14140 View commit details
    Browse the repository at this point in the history

  4. update base_getter.py function to make it unprivate

    @crispy-wonton
    crispy-wonton committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2f3f35a View commit details
    Browse the repository at this point in the history

  5. add bs4 to requirements

    @crispy-wonton
    crispy-wonton committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9b9f6a4 View commit details
    Browse the repository at this point in the history