Dont use args in tests

nestauk · Dec 8, 2023 · 4d32e01 · 4d32e01
1 parent 925b1b6
commit 4d32e01
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/ojd_daps_skills/pipeline/skill_ner/ner_spacy.py b/ojd_daps_skills/pipeline/skill_ner/ner_spacy.py
@@ -512,11 +512,11 @@ def load_model(self, model_folder, s3_download=True):
             self.ms_classifier = pickle.load(
                 open(os.path.join(model_folder, "ms_classifier.pkl"), "rb")
             )
+            return self.nlp
         except OSError:
             logger.info(
                 "Model not found locally - you may need to download it from S3 (set s3_download to True)"
             )
-        return self.nlp
 
 
 def parse_arguments(parser):

diff --git a/ojd_daps_skills/tests/test_extract_skills.py b/ojd_daps_skills/tests/test_extract_skills.py
@@ -15,6 +15,7 @@
 
 def test_load():
 
+    es = ExtractSkills(local=True)
     es.load()
 
     assert isinstance(es.nlp, spacy.lang.en.English)
@@ -31,6 +32,9 @@ def test_load():
 
 def test_get_skills():
 
+    es = ExtractSkills(local=True)
+    es.load()
+
     predicted_skills = es.get_skills(job_adverts)
 
     # The keys are the labels for every job prediction