feat(microservices): add gracefull shutdown option for nats server #13924
+105
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When using NATS transport for request/reply, there is no option for gracefully shutting down the server.
The NATS server close method implementation calls
natsClient.close()
and nullifies the client, meaning all the ongoing requests will be dropped.Issue Number: #13920
What is the new behavior?
Two options are added to NatsOptions,
gracefulShutdown
andgracePeriod
. IfgracefulShutdown
flag is provided, when calling the close method of ServerNats, first it will unsubscribe all the subscribed topics so the ServerNats will accept no new message. Also, it will wait forgracePeriod
and then try to nullify the client.When the shutdown hook is enabled, the
app.close
will be executed when some signal is sent to the app. Theapp.close
first calls theserver.close
and in the case of ServerNats and described behavior leads to processing all ongoing requests.Does this PR introduce a breaking change?
Other information