Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc-loader): add new options by generic props loader #13941

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wrspada02
Copy link

@wrspada02 wrspada02 commented Sep 3, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

The current grpc loader options for custom options has type any.

Issue Number: #13930

What is the new behavior?

This PR allows to pass generic type to the grpc loader options, and then, the custom options provided starts having type safety.

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

coveralls commented Sep 3, 2024

Pull Request Test Coverage Report for Build d2fb70fe-31dc-48d4-a362-48719c723572

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.213%

Totals Coverage Status
Change from base Build 0b2170fc-d850-443a-8e46-397cb7d6d6fd: 0.0%
Covered Lines: 6750
Relevant Lines: 7320

💛 - Coveralls

@wrspada02
Copy link
Author

Hello @micalevisk!

@wrspada02
Copy link
Author

@micalevisk Is there anything else you'd like I change?

@wrspada02
Copy link
Author

Hello @kamilmysliwiec, @micalevisk. Does this PR help your core with type safe on this grpc property?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants