fix(microservices): include discarded rmq client options #14059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all other properties, beside 'connectionOptions', from the socketOptions object ( of type AmqpConnectionManagerSocketOptions ) were being discarded on the creation of the AmqpConnectionManager client https://github.com/nestjs/nest/blob/master/packages/microservices/external/rmq-url.interface.ts#L47 https://github.com/jwalton/node-amqp-connection-manager/blob/v4.1.14/src/AmqpConnectionManager.ts#L46 nestjs#5788 (comment)
Pull Request Test Coverage Report for Build 5b2ae6c7-8738-41b7-8f07-24005283a5d9Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Configuration properties were being discarded upon rmqClient creation.
All other properties, beside 'connectionOptions', from the this.options.socketOptions object ( of type AmqpConnectionManagerSocketOptions ) were being discarded on the creation of the AmqpConnectionManager client
See:
https://github.com/nestjs/nest/blob/master/packages/microservices/external/rmq-url.interface.ts#L47 https://github.com/jwalton/node-amqp-connection-manager/blob/v4.1.14/src/AmqpConnectionManager.ts#L46
Issue Number: #5788 (comment)
What is the new behavior?
The other properties from the socketOptions key will now be included ( if present ) when the rmqClient is created
Does this PR introduce a breaking change?
Other information