Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.5 #814

Merged
merged 116 commits into from
Jul 9, 2023
Merged

0.2.5 #814

merged 116 commits into from
Jul 9, 2023

Conversation

DominiqueMakowski
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Patch coverage: 83.61% and project coverage change: +1.42 🎉

Comparison is base (3d5ecfc) 53.82% compared to head (294196f) 55.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   53.82%   55.24%   +1.42%     
==========================================
  Files         295      297       +2     
  Lines       13799    13918     +119     
==========================================
+ Hits         7427     7689     +262     
+ Misses       6372     6229     -143     
Impacted Files Coverage Δ
neurokit2/complexity/complexity.py 37.93% <ø> (ø)
neurokit2/complexity/fractal_tmf.py 28.57% <0.00%> (ø)
neurokit2/complexity/optim_complexity_tolerance.py 16.55% <ø> (ø)
neurokit2/complexity/utils_fractal_mandelbrot.py 12.00% <ø> (ø)
neurokit2/ecg/ecg_process.py 100.00% <ø> (ø)
neurokit2/ecg/ecg_quality.py 26.31% <0.00%> (ø)
neurokit2/eda/eda_process.py 92.00% <ø> (ø)
neurokit2/epochs/eventrelated_utils.py 91.66% <0.00%> (-3.17%) ⬇️
neurokit2/hrv/hrv_nonlinear.py 66.66% <0.00%> (ø)
neurokit2/hrv/intervals_process.py 90.00% <ø> (ø)
... and 31 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 11, 2023
@danibene
Copy link
Collaborator

danibene commented Jul 3, 2023

It seems the tests are failing because the newest version of sklearn wants us to use valid_metrics() instead of valid_metrics:

https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.KDTree.html

[Breaking] ecg_clean(): update biosppy method
@DominiqueMakowski
Copy link
Member Author

I suspect that some dependency creates some problems downstream, because tests are failing despite not having changed anything critical afaik

@danibene danibene mentioned this pull request Jul 5, 2023
2 tasks
@DominiqueMakowski
Copy link
Member Author

Should we merge?

@danibene
Copy link
Collaborator

danibene commented Jul 7, 2023

Should we merge?

Yes! I'll let you do the honors here

@codeclimate
Copy link

codeclimate bot commented Jul 8, 2023

Code Climate has analyzed commit 294196f and detected 0 issues on this pull request.

View more on Code Climate.

@DominiqueMakowski
Copy link
Member Author

Of course I had forgotten unpushed changes 😶‍🌫️
I added signal_fillmissing() to start adding a bit of control / flexibility in some cleaning pipelines (touched only PPG for now)

@danibene
Copy link
Collaborator

danibene commented Jul 8, 2023

@DominiqueMakowski I think we can merge with this!

To be considered maybe in a future version if we want to rather adopt the peak detection functions to exclude periods of missing data, especially if these periods are longer (so that we don't have a distorted heart rate due to filled in data)

@DominiqueMakowski DominiqueMakowski merged commit 366583e into master Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants