Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/docs asyncio warning #862

Merged
merged 7 commits into from
Jul 7, 2023

Conversation

danibene
Copy link
Collaborator

@danibene danibene commented Jul 5, 2023

Description

This PR aims to fix the following warning (not sure how to test without opening PR, so wait until docs passes before merging please)

D:\a\NeuroKit\NeuroKit\docs\examples\bio_custom\bio_custom.ipynb: Executing notebook using local CWD [mystnb]
C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\zmq\_future.py:681: RuntimeWarning: Proactor event loop does not implement add_reader family of methods required for zmq. Registering an additional selector thread for add_reader support via tornado. Use `asyncio.set_event_loop_policy(WindowsSelectorEventLoopPolicy())` to avoid this warning.
  self._get_loop()

@danibene danibene changed the base branch from master to dev July 5, 2023 12:27
@codeclimate
Copy link

codeclimate bot commented Jul 5, 2023

Code Climate has analyzed commit fbcb6b6 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Patch coverage: 85.91% and project coverage change: +1.13 🎉

Comparison is base (f6d4d2d) 54.12% compared to head (f823fb9) 55.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #862      +/-   ##
==========================================
+ Coverage   54.12%   55.25%   +1.13%     
==========================================
  Files         295      296       +1     
  Lines       13810    13914     +104     
==========================================
+ Hits         7474     7688     +214     
+ Misses       6336     6226     -110     
Impacted Files Coverage Δ
neurokit2/eda/eda_process.py 92.00% <ø> (ø)
neurokit2/misc/report.py 94.18% <ø> (+2.32%) ⬆️
neurokit2/ppg/ppg_clean.py 70.58% <33.33%> (ø)
neurokit2/ppg/ppg_methods.py 85.29% <66.66%> (ø)
neurokit2/emg/emg_clean.py 83.33% <75.00%> (+1.51%) ⬆️
neurokit2/events/events_find.py 80.00% <75.00%> (-0.96%) ⬇️
neurokit2/ecg/ecg_clean.py 86.95% <85.71%> (+0.19%) ⬆️
neurokit2/signal/signal_filter.py 70.90% <86.66%> (+2.28%) ⬆️
neurokit2/emg/emg_methods.py 90.00% <90.00%> (ø)
neurokit2/emg/emg_plot.py 93.33% <90.24%> (-4.45%) ⬇️
... and 3 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danibene
Copy link
Collaborator Author

danibene commented Jul 5, 2023

I vaguely remember this already being an issue, not sure what was done:

C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\sklearn\utils\extmath.py:193: RuntimeWarning: invalid value encountered in matmul
  ret = a @ b
<<<-------------------------------------------------------------------------

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 5, 2023
@danibene
Copy link
Collaborator Author

danibene commented Jul 5, 2023

@DominiqueMakowski the docs check passes when the versions of numpy and ipykernel are downgraded, should ideally be investigated but for now are you fine with me merging with these fixed versions of numpy/ipykernel?

@DominiqueMakowski
Copy link
Member

More than fine, so we can release the dev

Thanks again Dani for all your work :)

@danibene danibene merged commit 49b5268 into neuropsychology:dev Jul 7, 2023
9 checks passed
@danibene danibene deleted the fix/docs_asyncio_warning branch July 7, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants