-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/docs asyncio warning #862
Fix/docs asyncio warning #862
Conversation
Code Climate has analyzed commit fbcb6b6 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #862 +/- ##
==========================================
+ Coverage 54.12% 55.25% +1.13%
==========================================
Files 295 296 +1
Lines 13810 13914 +104
==========================================
+ Hits 7474 7688 +214
+ Misses 6336 6226 -110
☔ View full report in Codecov by Sentry. |
I vaguely remember this already being an issue, not sure what was done:
|
@DominiqueMakowski the docs check passes when the versions of numpy and ipykernel are downgraded, should ideally be investigated but for now are you fine with me merging with these fixed versions of numpy/ipykernel? |
More than fine, so we can release the dev Thanks again Dani for all your work :) |
Description
This PR aims to fix the following warning (not sure how to test without opening PR, so wait until docs passes before merging please)