Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Respiratory Amplitude Variability (RAV) #873

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Conversation

DominiqueMakowski
Copy link
Member

#853

I'm not aware of much literature on that, but it doesn't seem absurd as a potential feature of interest

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.16% ⚠️

Comparison is base (a802b57) 55.23% compared to head (6834e14) 55.08%.
Report is 50 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #873      +/-   ##
==========================================
- Coverage   55.23%   55.08%   -0.16%     
==========================================
  Files         297      300       +3     
  Lines       13917    14008      +91     
==========================================
+ Hits         7687     7716      +29     
- Misses       6230     6292      +62     
Files Changed Coverage Δ
neurokit2/rsp/__init__.py 100.00% <100.00%> (ø)
neurokit2/rsp/rsp_intervalrelated.py 94.73% <100.00%> (+1.63%) ⬆️
neurokit2/rsp/rsp_rav.py 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danibene
Copy link
Collaborator

@DominiqueMakowski just had a quick look so far - do you think you could add some tests?

@DominiqueMakowski DominiqueMakowski merged commit 942ceb5 into dev Aug 22, 2023
9 checks passed
@DominiqueMakowski DominiqueMakowski deleted the rsp_rav branch August 22, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants