Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add random_state to complexity_symbolize #881

Merged

Conversation

danibene
Copy link
Collaborator

Description

This PR aims to allow for setting the random seed in complexity_symbolize(). See also #879

Proposed Changes

I added a random_state argument to the complexity_symbolize() function so that the seed is passed to scipy.cluster.vq.kmeans2()

Checklist

  • I have read the CONTRIBUTING file.
  • My PR is targetted at the dev branch (and not towards the master branch).

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.01% 🎉

Comparison is base (a802b57) 55.23% compared to head (22323a7) 55.25%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #881      +/-   ##
==========================================
+ Coverage   55.23%   55.25%   +0.01%     
==========================================
  Files         297      297              
  Lines       13917    13918       +1     
==========================================
+ Hits         7687     7690       +3     
+ Misses       6230     6228       -2     
Files Changed Coverage Δ
neurokit2/complexity/utils_complexity_symbolize.py 20.90% <75.00%> (+1.46%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danibene danibene merged commit 47810f7 into neuropsychology:dev Aug 11, 2023
9 checks passed
@danibene danibene deleted the feature/seed_complexity_symbolize branch August 11, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants