Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] download zip #882
[Feature] download zip #882
Changes from 19 commits
ed20882
d068a88
8f57246
61a3547
e8c0a0c
ec5ceb1
50340da
7427cf3
d353f9e
2e34a64
d6c2d58
d14357d
41840d6
2302082
7050137
1c42eb6
9f978c4
394e32d
9bbdd2c
0a2e20f
5750b79
66724c5
437f219
71a2516
69e62d8
4f704ae
ec4c058
4b3ac76
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we do this somewhat more "generic", like something like
download_from_url()
and then there is anunzip=True
argument that triggers, if the content is detected to be a zipped file, automatically unzips it?So that we could use that function for both zipped un non-zipped stuff? (although I'm not sure if there would be such a need)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I just realized you meant downloading any files from a url and not just a zip. Yeah sure I can do that too (though I feel like then we should still have
download_zip()
that callsdownload_from_url()
, since there are zip-specific functionalities in the function like removing the original zip file), but I have to go now, can get back to it in a few days probably