Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ppg_peaks() now has artifact correction #890

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

DominiqueMakowski
Copy link
Member

@DominiqueMakowski DominiqueMakowski commented Aug 23, 2023

  • Added fixpeaks as part of ppg_peaks() routine. Should we enable it as default in ppg_process? Needs some testing

@DominiqueMakowski DominiqueMakowski changed the title add fixpeak to ppg_peaks [Feature] ppg_peaks() now has artifact correction Aug 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage: 58.97% and project coverage change: -0.02% ⚠️

Comparison is base (4bf8071) 55.18% compared to head (781ebd6) 55.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #890      +/-   ##
==========================================
- Coverage   55.18%   55.17%   -0.02%     
==========================================
  Files         302      302              
  Lines       14103    14134      +31     
==========================================
+ Hits         7783     7798      +15     
- Misses       6320     6336      +16     
Files Changed Coverage Δ
neurokit2/ecg/ecg_segment.py 90.38% <50.00%> (-1.62%) ⬇️
neurokit2/ppg/ppg_segment.py 80.00% <50.00%> (-3.34%) ⬇️
neurokit2/ecg/ecg_peaks.py 80.30% <52.94%> (-9.50%) ⬇️
neurokit2/ecg/ecg_plot.py 88.46% <66.66%> (+0.96%) ⬆️
neurokit2/ppg/ppg_peaks.py 78.78% <66.66%> (-10.11%) ⬇️
neurokit2/ppg/ppg_plot.py 50.00% <66.66%> (+2.17%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominiqueMakowski DominiqueMakowski merged commit 29f666f into dev Aug 23, 2023
8 of 9 checks passed
@DominiqueMakowski DominiqueMakowski deleted the ppg_fixpeaks branch August 23, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants