Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] typos #896

Merged
Merged

Conversation

danibene
Copy link
Collaborator

@danibene danibene commented Sep 6, 2023

Proposed Changes

I fixed some typos in PULL_REQUEST_TEMPLATE.md, entropy_shannon(), and hrv_nonlinear().

Edit: I have also attempted to address a FutureWarning raised in the docs check by ecg_delineate

Edit x2: This attempt failed (see #897) so nevermind, let's just merge the typo changes

Checklist

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (60884fb) 55.22% compared to head (619c8d6) 55.19%.
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #896      +/-   ##
==========================================
- Coverage   55.22%   55.19%   -0.04%     
==========================================
  Files         302      302              
  Lines       14141    14142       +1     
==========================================
- Hits         7810     7805       -5     
- Misses       6331     6337       +6     
Files Changed Coverage Δ
neurokit2/complexity/entropy_shannon.py 83.33% <ø> (ø)
neurokit2/hrv/hrv_nonlinear.py 66.66% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominiqueMakowski DominiqueMakowski merged commit d867214 into neuropsychology:dev Sep 7, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants