Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] docs build warning #898

Merged
merged 15 commits into from
Sep 12, 2023

Conversation

danibene
Copy link
Collaborator

@danibene danibene commented Sep 7, 2023

Description

This PR aims to address a warning in the docs check caused by ecg_delineate().

Proposed Changes

See #897 (comment)

Checklist

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 58.06% and project coverage change: +0.02% 🎉

Comparison is base (d867214) 55.19% compared to head (65581dd) 55.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #898      +/-   ##
==========================================
+ Coverage   55.19%   55.22%   +0.02%     
==========================================
  Files         302      302              
  Lines       14142    14143       +1     
==========================================
+ Hits         7806     7810       +4     
+ Misses       6336     6333       -3     
Files Changed Coverage Δ
neurokit2/complexity/entropy_spectral.py 25.00% <0.00%> (ø)
neurokit2/complexity/fractal_psdslope.py 17.64% <0.00%> (ø)
neurokit2/ecg/ecg_phase.py 85.29% <ø> (ø)
neurokit2/misc/progress_bar.py 14.28% <ø> (ø)
neurokit2/signal/signal_fillmissing.py 28.57% <0.00%> (ø)
neurokit2/ecg/ecg_quality.py 26.31% <30.00%> (ø)
neurokit2/stats/standardize.py 65.85% <33.33%> (ø)
neurokit2/ecg/ecg_delineate.py 80.56% <100.00%> (ø)
neurokit2/emg/emg_activation.py 90.14% <100.00%> (ø)
neurokit2/emg/emg_plot.py 88.15% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 7, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 11, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 11, 2023
@DominiqueMakowski
Copy link
Member

lol that was tedious!

@DominiqueMakowski DominiqueMakowski merged commit ecb4752 into neuropsychology:dev Sep 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants