[Fix] Fixed rodrigues2021 ECG peaks detector (make it work with < 50Hz sampling rate) #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at fixing a bug where 'Nd' variable in _ecg_findpeaks_rodrigues was set to 0 in case of sampling_rate too small, effectively nulling the ECG first derivative
Proposed Changes
I have set N to be at least 2, so that Nd is at least 1.
Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)