Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fixed rodrigues2021 ECG peaks detector (make it work with < 50Hz sampling rate) #949

Conversation

LucaCerina
Copy link
Contributor

Description

This PR aims at fixing a bug where 'Nd' variable in _ecg_findpeaks_rodrigues was set to 0 in case of sampling_rate too small, effectively nulling the ECG first derivative

Proposed Changes

I have set N to be at least 2, so that Nd is at least 1.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

Copy link

welcome bot commented Jan 17, 2024

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@DominiqueMakowski DominiqueMakowski changed the title Added minimum N in rodrigues2021 peaks detector [Fix] Fixed rodrigues2021 ECG peaks detector (make it work with < 50Hz sampling rate) Jan 17, 2024
@DominiqueMakowski
Copy link
Member

Nice thanks!

@DominiqueMakowski DominiqueMakowski merged commit b25b8bb into neuropsychology:dev Jan 17, 2024
8 checks passed
Copy link

welcome bot commented Jan 17, 2024

landing
Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants