Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] rr xcorr arange steps don't match #960

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

birm
Copy link
Contributor

@birm birm commented Feb 5, 2024

Line 128 uses step size of 0.25/50, but line 137 uses 0.25/60

I think this is a typo, but please close if I'm wrong!

Line 128 uses step size of 0.25/50, but line 137 uses 0.25/60

I think this is a typo, but please close if I'm wrong!
Copy link

welcome bot commented Feb 5, 2024

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@birm birm changed the title [BUG] rr xcorr arange steps don't match [FIX] rr xcorr arange steps don't match Feb 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (56aba7f) 54.59% compared to head (c016a9b) 54.59%.

Files Patch % Lines
neurokit2/rsp/rsp_rate.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #960   +/-   ##
=======================================
  Coverage   54.59%   54.59%           
=======================================
  Files         304      304           
  Lines       14325    14325           
=======================================
  Hits         7821     7821           
  Misses       6504     6504           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominiqueMakowski
Copy link
Member

good catch, thanks @birm! and sorry for the delay in reviewing this

@DominiqueMakowski DominiqueMakowski merged commit f62627d into neuropsychology:dev Mar 3, 2024
7 of 8 checks passed
Copy link

welcome bot commented Mar 3, 2024

landing
Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants