Fix bug in Azure Function App ARM when using Blob Storage #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the PublicNetworkAccess property from SiteConfig.PublicNetworkAccess to Site.PublicNetworkAccess as Azure does not allow this setting to be changed via the SiteConfig object
|
|
davza
changed the title
Sivakumar3695
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug that causes the provisioning of the Azure Function App that is used to forward the logs from a Storage Account to New Relic to fail.
Change details
Moved the PublicNetworkAccess property from SiteConfig.PublicNetworkAccess to Site.PublicNetworkAccess.
Error details
To reproduce the error, follow the instructions for Deploying the New Relic Blob Storage ARM template.
The ARM template fails to deploy the Function App with the error:
There was a conflict. SiteConfig.PublicNetworkAccess cannot be set by itself. Please use the Site.PublicNetworkAccess property.
(Target: [azure_resource_identifier])