Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Centralize Event Buffers #1171

Closed
wants to merge 8 commits into from
Closed

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Sep 1, 2024

Standardize and centralize the event buffer pattern across all features, to allow for consistent storage, harvesting, and cache management.

Overview

All features would now have a standard way to store event data. And external (future) modules would have a standard way to access that data, through the runtime event manager object. All data stores are size-managed by the existing event-buffer class, which makes managing the data constraints and short-circuits easier.

Related Issue(s)

This was generated from innovation work

Testing

Tests have had a major overhaul to support the change to the event buffer pattern

Copy link

github-actions bot commented Sep 1, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.69 kB / 11.1 kB (gzip) 30.68 kB / 11.13 kB (gzip) -0.04% / 0.23% (gzip)
lite async-chunk 50.27 kB / 16.33 kB (gzip) 50.35 kB / 16.38 kB (gzip) 0.16% / 0.29% (gzip)
pro loader 51.33 kB / 17.72 kB (gzip) 51.28 kB / 17.75 kB (gzip) -0.09% / 0.15% (gzip)
pro async-chunk 96.81 kB / 29.3 kB (gzip) 96.45 kB / 29.17 kB (gzip) -0.37% / -0.42% (gzip)
spa loader 58.98 kB / 20.1 kB (gzip) 58.93 kB / 20.11 kB (gzip) -0.09% / 0.07% (gzip)
spa async-chunk 111.87 kB / 33.64 kB (gzip) 111.5 kB / 33.51 kB (gzip) -0.34% / -0.4% (gzip)

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.72%. Comparing base (b12131c) to head (53b7cc7).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/features/page_view_timing/aggregate/index.js 44.44% 2 Missing and 3 partials ⚠️
src/features/logging/aggregate/index.js 83.33% 1 Missing and 1 partial ⚠️
src/features/ajax/aggregate/index.js 90.90% 0 Missing and 1 partial ⚠️
src/features/jserrors/instrument/index.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   88.45%   90.72%   +2.27%     
==========================================
  Files         165      161       -4     
  Lines        7249     7065     -184     
  Branches     1484     1397      -87     
==========================================
- Hits         6412     6410       -2     
+ Misses        716      574     -142     
+ Partials      121       81      -40     
Flag Coverage Δ
integration-tests 91.68% <100.00%> (-0.01%) ⬇️
unit-tests 83.85% <83.90%> (+4.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah changed the title [innovation]: centralize event buffers feat: Centralize Event Buffers Sep 12, 2024
Copy link

github-actions bot commented Sep 13, 2024

Static Badge

Last ran on September 12, 2024 21:59:58 CDT
Checking merge of (53b7cc7) into main (b12131c)

@metal-messiah metal-messiah marked this pull request as ready for review September 13, 2024 14:03
@metal-messiah
Copy link
Member Author

putting back into draft mode until CDD is agreed upon

@metal-messiah metal-messiah marked this pull request as draft September 23, 2024 15:46
@cwli24 cwli24 closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants