-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Centralize Event Buffers #1171
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
+ Coverage 88.45% 90.72% +2.27%
==========================================
Files 165 161 -4
Lines 7249 7065 -184
Branches 1484 1397 -87
==========================================
- Hits 6412 6410 -2
+ Misses 716 574 -142
+ Partials 121 81 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
putting back into draft mode until CDD is agreed upon |
Standardize and centralize the event buffer pattern across all features, to allow for consistent storage, harvesting, and cache management.
Overview
All features would now have a
standard
way to store event data. And external (future) modules would have a standard way to access that data, through the runtime event manager object. All data stores are size-managed by the existing event-buffer class, which makes managing the data constraints and short-circuits easier.Related Issue(s)
This was generated from innovation work
Testing
Tests have had a major overhaul to support the change to the event buffer pattern