Replace unmaintained HammerJS dependency with VueUse #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
force-pushed
the
deps/replace-hammerjs
branch
from
f2b9ede
to
137b6a5
Compare
Pytal
approved these changes
Mar 16, 2023
susnux
force-pushed
the
deps/replace-hammerjs
branch
from
137b6a5
to
31cf31e
Compare
raimund-schluessler
requested changes
Mar 16, 2023
susnux
force-pushed
the
deps/replace-hammerjs
branch
from
31cf31e
to
05e0586
Compare
ShGKme
requested changes
May 9, 2023
susnux
force-pushed
the
deps/replace-hammerjs
branch
2 times, most recently
from
0052761
to
ffdeede
Compare
|
Any changes or just rebase? :) |
Ref: hammerjs/hammer.js#1278 Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
deps/replace-hammerjs
branch
from
ffdeede
to
0917f4b
Compare
Before that comment: Rebase. After it: Changes 😉 screen-20230515-135431.2.mp4 |
ShGKme
approved these changes
May 15, 2023
There was a problem hiding this comment.
Tested on Android - Vivaldi (Chromium) and Firefox - works fine.
@marcoambrosini Could you also test on iPhone Safari?
marcoambrosini
approved these changes
May 15, 2023
susnux
added
4. to release
raimund-schluessler
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HammerJS is unmaintained, ref: hammerjs/hammer.js#1278
Replaced with VueUse which will be quite useful as we can also use it for #3893 so we can replace two unmaintained dependencies with one maintained one.
(Not relevant but this also will fix issues when building nextcloud-vue with vite (maybe in the future)).