Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): don't crash subscription on invalid calendar object #48519

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 2, 2024

Summary

Local version of #48349 to have a full CI run.

TODO

  • CI
  • Review

Checklist

@kesselb kesselb added bug 3. to review Waiting for reviews labels Oct 2, 2024
@kesselb kesselb added this to the Nextcloud 31 milestone Oct 2, 2024
@kesselb kesselb self-assigned this Oct 2, 2024
@kesselb kesselb added the feature: caldav Related to CalDAV internals label Oct 2, 2024
@SebastianKrupinski SebastianKrupinski merged commit 2d004c3 into master Oct 2, 2024
177 checks passed
@SebastianKrupinski SebastianKrupinski deleted the bug/48518/ignore-invalid-dates branch October 2, 2024 13:04
@kesselb
Copy link
Contributor Author

kesselb commented Oct 2, 2024

/backport to stable30

@SebastianKrupinski
Copy link
Contributor

/backport to stable29

@kesselb
Copy link
Contributor Author

kesselb commented Oct 2, 2024

The user wrote that the problem does not happen on 29.0.7 and the line that throws the exception does not exist in 29, so I closed the 29 backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Failure on subscribing to a public Google calendar
4 participants