Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to NX 20 #4596

Merged
merged 2 commits into from
Nov 19, 2024
Merged

chore: update to NX 20 #4596

merged 2 commits into from
Nov 19, 2024

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Nov 16, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

While migrating the build pipeline to GitHub actions, I noticed some builds were randomly failing during the setup phase with the error error /home/runner/work/platform/platform/node_modules/@angular-eslint/builder/node_modules/nx, /home/runner/work/platform/platform/node_modules/@angular-eslint/schematics/node_modules/nx: Command failed.. This happens on any build step, e.g. https://github.com/ngrx/platform/actions/runs/11863341146/job/33064638143?pr=4595

What is the new behavior?

Closes #4588

I don't know why, bit it seems like other's also have a similar problem. https://github.com/nrwl/nx/issues?q=is:issue%20state:open%20%22Postinstall%20script%22

I want to test if upgrading NX solves this problem.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit d895e10
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6739f3bf1ed93d00089b9904

"@angular-eslint/schematics": "18.0.1",
"@angular-eslint/template-parser": "18.0.1",
"@angular-eslint/test-utils": "18.0.1",
"@angular-eslint/builder": "18.4.0",
Copy link
Member Author

@timdeschryver timdeschryver Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating NX AND @angular-eslint seems to do the trick.

The culprit was different NX versions, which both ran the post-install script. Sometimes this failed because one process would lock the other.

At https://github.com/ngrx/platform/actions/runs/11879387277 you can see 5 succeeding runs.

This means this PR closes #4588

Copy link
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes but the majority comes from the eslint switch.

Did a test run with testing signals, starting documentation, serving example-app and building the three main libraries.

The example failed, but there is big update #4487 in the queue which depends on this particular PR. That one will fix the example app.

Looks good to me. Well done Tim. I guess it wasn't just a walk in the park 👍

@brandonroberts brandonroberts merged commit 698f0b7 into main Nov 19, 2024
11 checks passed
@brandonroberts brandonroberts deleted the nx-20 branch November 19, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update typescript-eslint
4 participants