-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to latest angular and nx #308
base: main
Are you sure you want to change the base?
Conversation
@@ -5,65 +5,67 @@ | |||
"postinstall": "node ./decorate-angular-cli.js", | |||
"build": "nx run-many --target=build --all", | |||
"ci": "yarn lint && yarn test && yarn build", | |||
"lint": "nx workspace-lint && nx run-many --target=lint --all --max-warnings=0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this command is no longer needed.
"@angular/core": "^15.0.0", | ||
"@angular/router": "^15.0.0", | ||
"@ngrx/component-store": "^15.0.0", | ||
"@angular/core": "^15.0.0 || ^16.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm it DOES work in 16, we have been using it for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have recently put the library into production in a big Angular 16 app with complex routing configurations and route state usage and I can also confirm this. However, Router Component Store will follow the versioning scheme recommended by Angular: One major version of Router Component Store for every major version of Angular (and NgRx Component Store).
Thank you for your contribution, @yharaskrik 🙇♂️ I'm glad that you found Router Component Store useful! Currently, I'm writing hundreds of tests to cover a wide range of route configurations before releasing the first stable version which will be version 15.0.0. Following that, a major version of the library will be released for each major version of Angular (16.x, 17.x, ...) and NgRx Component Store. Feel free to join the ngworkers Discord server and we can discuss the plans further. I'm considering whether any breaking changes are needed before/after the first stable version. |
Feel free to close this if you already have plans with all this moving forward then! No worries on my end. |
Updates:
Sets the peer deps to
^15 || ^16
to get rid of warnings when installing this library (which does work for 16)