Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace external StrictRouteParams with simple type #325

Merged
merged 1 commit into from
Sep 16, 2024
Merged

refactor: replace external StrictRouteParams with simple type #325

merged 1 commit into from
Sep 16, 2024

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Sep 16, 2024 •
edited
Loading

Closes #327.

Refactors

  • Rename StrictRouteParams to InternalStrictRouteParams and use it internally to enforce compatibility with Angular's Params type
  • Replace the exposed StrictRouteParams with a simple type

@LayZeeDK LayZeeDK marked this pull request as ready for review September 16, 2024 19:29
@LayZeeDK LayZeeDK merged commit f7ea0d7 into main Sep 16, 2024
7 checks passed
@LayZeeDK LayZeeDK deleted the refactor/simplify-strictrouteparams branch September 16, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal utility types exposed with StrictRouteParams
1 participant
@LayZeeDK