Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace external StrictRouteData with simple type #326

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

LayZeeDK
Copy link
Member

@LayZeeDK LayZeeDK commented Sep 16, 2024

Closes #328.

Refactors

  • Rename StrictRouteData to InternalStrictRouteData and use it internally to enforce compatibility with Angular's Data type
  • Replace the exposed StrictRouteData with a simple type

@LayZeeDK LayZeeDK changed the title refactor: replace external StrictRouteParams with simple type refactor: replace external StrictRouteData with simple type Sep 16, 2024
@LayZeeDK LayZeeDK force-pushed the refactor/simplify-strictroutedata branch from e429010 to 70cba4c Compare September 16, 2024 19:42
@LayZeeDK LayZeeDK force-pushed the refactor/simplify-strictroutedata branch from 70cba4c to 807b447 Compare September 16, 2024 19:46
@LayZeeDK LayZeeDK marked this pull request as ready for review September 16, 2024 19:47
@LayZeeDK LayZeeDK merged commit 44b1d0c into main Sep 16, 2024
7 checks passed
@LayZeeDK LayZeeDK deleted the refactor/simplify-strictroutedata branch September 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal utility types exposed with StrictRouteData
1 participant