Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: bump golangci-lint due to some memory issues #22

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Sep 18, 2024

PR Type

Enhancement


Description

  • Upgraded golangci-lint from version 1.60.3 to 1.61.0
  • Updated the sha256 hash for the source to match the new version
  • Updated the vendorHash to correspond with the new version
  • This update addresses some memory issues mentioned in the commit message

Changes walkthrough 📝

Relevant files
Dependencies
go.nix
Upgrade golangci-lint to version 1.61.0                                   

overlays/go.nix

  • Updated golangci-lint version from 1.60.3 to 1.61.0
  • Updated sha256 hash for the source
  • Updated vendorHash
  • +3/-3     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @github-actions github-actions bot added the enhancement New feature or request label Sep 18, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    github-actions bot commented Sep 18, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Use a variable for the version number to improve maintainability

    Consider using a variable for the version number to ensure consistency throughout
    the file and make future updates easier.

    overlays/go.nix [17-21]

    -version = "1.61.0";
    +golangci_lint_version = "1.61.0";
    +version = golangci_lint_version;
     src = prev.fetchFromGitHub {
       owner = "golangci";
       repo = "golangci-lint";
    -  rev = "v${version}";
    +  rev = "v${golangci_lint_version}";
     
    Suggestion importance[1-10]: 8

    Why: Using a variable for the version number enhances maintainability by ensuring consistency and making future updates easier across the file.

    8
    Maintainability
    Add a comment to explain the reason for the version bump

    Consider adding a comment explaining the reason for the version bump, such as the
    memory issues mentioned in the PR title. This will help future maintainers
    understand the context of this change.

    overlays/go.nix [17]

    +# Bumped version to address memory issues (see PR title)
     version = "1.61.0";
     
    Suggestion importance[1-10]: 7

    Why: Adding a comment explaining the version bump reason improves code maintainability and provides context for future developers.

    7

    @dbarrosop dbarrosop merged commit e07fe4b into main Sep 18, 2024
    3 checks passed
    @dbarrosop dbarrosop deleted the golagci-lint branch September 18, 2024 09:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants