Fix bug

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/AggregatorImplementer.java

@@ -390,7 +390,7 @@ private MethodSpec addRawVector(boolean masked) {
             builder.addParameter(BOOLEAN_VECTOR, "mask");
         }
 
-        if (stateTypeHasSeen) {
+        if (stateTypeHasSeen && masked == false) {
             builder.addStatement("state.seen(true)");
         }
         if (valuesIsBytesRef) {
@@ -403,6 +403,9 @@ private MethodSpec addRawVector(boolean masked) {
             if (masked) {
                 builder.beginControlFlow("if (mask.getBoolean(i) == false)").addStatement("continue").endControlFlow();
             }
+            if (stateTypeHasSeen && masked) {
+                builder.addStatement("state.seen(true)");
+            }
             combineRawInput(builder, "vector");
         }
         builder.endControlFlow();

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/ConstantBooleanExpressionEvaluator.java

@@ -9,9 +9,12 @@
 
 import org.elasticsearch.compute.data.Block;
 import org.elasticsearch.compute.data.BlockFactory;
+import org.elasticsearch.compute.data.BooleanVector;
 import org.elasticsearch.compute.data.Page;
 import org.elasticsearch.compute.operator.EvalOperator;
 
+import static org.elasticsearch.test.ESTestCase.randomBoolean;
+
 /**
  * An {@link EvalOperator.ExpressionEvaluator} that evaluates to a constant boolean value.
  */
@@ -22,7 +25,15 @@ public static EvalOperator.ExpressionEvaluator.Factory factory(boolean value) {
 
     @Override
     public Block eval(Page page) {
-        return factory.newConstantBooleanVector(value, page.getPositionCount()).asBlock();
+        if (randomBoolean()) {
+            return factory.newConstantBooleanVector(value, page.getPositionCount()).asBlock();
+        }
+        try (BooleanVector.Builder builder = factory.newBooleanVectorFixedBuilder(page.getPositionCount())) {
+            for (int p = 0; p < page.getPositionCount(); p++) {
+                builder.appendBoolean(value);
+            }
+            return builder.build().asBlock();
+        }
     }
 
     @Override

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/AggregatorFunctionTestCase.java

@@ -190,7 +190,7 @@ public void testAllFiltered() {
         assertOutputFromEmpty(results.get(0).getBlock(0));
     }
 
-    public final void testNoneFiltered() {
+    public void testNoneFiltered() {
         Operator.OperatorFactory factory = simpleWithMode(
             AggregatorMode.SINGLE,
             agg -> new FilteredAggregatorFunctionSupplier(agg, ConstantBooleanExpressionEvaluator.factory(true))

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/aggregation/FilteredAggregatorFunctionTests.java

@@ -94,6 +94,11 @@ public void checkUnclosed() {
         assertThat(unclosed, empty());
     }
 
+    @Override
+    public void testNoneFiltered() {
+        assumeFalse("can't double filter. tests already filter.", true);
+    }
+
     @Override
     public void testAllFiltered() {
         assumeFalse("can't double filter. tests already filter.", true);