Fix #2499: Status update regression. #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhasse
reviewed
Sep 30, 2024
misc/output_test.py
Outdated
| If False (the default), this runs Ninja in a pty to simulate | ||
| a smart terminal (this feature cannot work on Windows!). | ||
|
|
||
| raw_output: set to True to return the raw, unfilted command |
There was a problem hiding this comment.
Fixed. Thanks.
misc/output_test.py
Outdated
| env: Optional environment dictionary to run the command in. | ||
|
|
||
| Returns: | ||
| An UTF-8 corresponding to the output (stdout only) of the |
PR ninja-build#2487 introduced a regression, where a completed command without an output would force a newline, preventing the next status update to appear on the same line in smart terminals. This fixes the issue by adding the missing `!outputs.empty()` condition + adding a proper regression test to catch future breaks. Fixed: ninja-build#2499
digit-google
force-pushed
the
fix-output-regression
branch
from
df167c8
to
562cee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2487 introduced a regression, where a completed command without an output would force a newline, preventing the next status update to appear on the same line in smart terminals.
This fixes the issue by adding the missing
!outputs.empty()condition + adding a proper regression test to catch future breaks.Fixed: #2499