Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReproIn heuristic uses phase suffix instead of part-phase #769

Open
tsalo opened this issue Jun 13, 2024 · 0 comments · May be fixed by #770
Open

ReproIn heuristic uses phase suffix instead of part-phase #769

tsalo opened this issue Jun 13, 2024 · 0 comments · May be fixed by #770

Comments

@tsalo
Copy link
Member

tsalo commented Jun 13, 2024

Summary

The ReproIn heuristic (reproin) currently uses suffixes to distinguish complex-valued fMRI data (see below). However, the phase suffix is deprecated in favor of the part entity.

elif "P" in s.image_type:
datatype_suffix = "phase"
elif "M" in s.image_type:
datatype_suffix = "bold"

The difficult thing is that infotodict is run separately on each run loops over runs, and magnitude and phase data from the same run are typically (at least with the CMRR MB sequence) split into separate folders of DICOMs (magnitude first). I don't know how to flexibly identify magnitude BOLD runs that need part-mag (i.e., runs with phase data also reconstructed) vs. those that don't (magnitude-only reconstruction).

I'm thinking maybe that the filename_suffix_parts list could be built with part included by default, then it could be collected across runs, and then if there aren't any cases where everything else is the same except for part, the part entity could be removed.

Platform details:

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant