Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated "_phase" suffix in reproin heuristic with "part-phase" entity #770

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jun 21, 2024

Closes #769. This is working on DICOMs associated with https://openneuro.org/datasets/ds005250.

Changes proposed:

  • Track previous and next sequence info in ReproIn's infotodict.
  • Rename s variable to curr_seqinfo for improved clarity. Moved to Rename s variable to curr_seqinfo in reproin heuristic #779.
  • For non-SBRef, non-fieldmap scans, set "part" entity to "phase" for phase data instead of setting the suffix to "phase".
  • For magnitude non-SBRef, non-fieldmap scans, check if the next sequence has the same series_description and is a phase scan. If it is, set "part" to "mag".

@tsalo tsalo added the BIDS label Jun 21, 2024
@tsalo tsalo marked this pull request as draft June 21, 2024 16:10
@tsalo tsalo marked this pull request as ready for review June 24, 2024 14:34
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (a0a3635) to head (59bb2ec).

Files Patch % Lines
heudiconv/heuristics/reproin.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   82.08%   82.15%   +0.06%     
==========================================
  Files          42       42              
  Lines        4215     4230      +15     
==========================================
+ Hits         3460     3475      +15     
  Misses        755      755              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo requested a review from yarikoptic June 24, 2024 15:00
@yarikoptic
Copy link
Member

Rename s variable to curr_seqinfo for improved clarity.

yeah, but complicates review a little due to diff now including changes I can ignore or not and need to decide when looking...

Could you submit a separate PR with that typo fix and such a rename (so no functionality change) and then let's improve this one -- yet to grasp on all the changes, and as we do not have any nice testing for reproin heuristic, I wonder how we could add one :-/ I would really be shy to accept without some way to test. Locally I could do using smth like https://github.com/nipy/heudiconv/blob/master/utils/test-compare-two-versions.sh but could we do better?!

@tsalo
Copy link
Member Author

tsalo commented Aug 8, 2024

👍 I've opened #779 with the variable name change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReproIn heuristic uses phase suffix instead of part-phase
2 participants