-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated "_phase" suffix in reproin heuristic with "part-phase" entity #770
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 82.08% 82.15% +0.06%
==========================================
Files 42 42
Lines 4215 4230 +15
==========================================
+ Hits 3460 3475 +15
Misses 755 755 ☔ View full report in Codecov by Sentry. |
yeah, but complicates review a little due to diff now including changes I can ignore or not and need to decide when looking... Could you submit a separate PR with that typo fix and such a rename (so no functionality change) and then let's improve this one -- yet to grasp on all the changes, and as we do not have any nice testing for reproin heuristic, I wonder how we could add one :-/ I would really be shy to accept without some way to test. Locally I could do using smth like https://github.com/nipy/heudiconv/blob/master/utils/test-compare-two-versions.sh but could we do better?! |
👍 I've opened #779 with the variable name change. |
Closes #769. This is working on DICOMs associated with https://openneuro.org/datasets/ds005250.
Changes proposed:
infotodict
.RenameMoved to Rename s variable to curr_seqinfo in reproin heuristic #779.s
variable tocurr_seqinfo
for improved clarity.series_description
and is a phase scan. If it is, set "part" to "mag".