Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-compare-two-versions.sh: also ignore differences in HeudiconvVersion field in jsons since we have it there now #685

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

yarikoptic
Copy link
Member

FWIW, attn @neurorepro - might be of interest. I used it e.g. now to compare effects of #684 . Might come handy in your "hacking heudiconv" days.

…sion field in jsons since we have it there now
@yarikoptic yarikoptic added the internal Changes only affect the internal API label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7093ed4) 82.00% compared to head (35b101a) 82.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files          41       41           
  Lines        4130     4130           
=======================================
  Hits         3387     3387           
  Misses        743      743           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic merged commit 83c8424 into nipy:master Jun 9, 2023
@github-actions
Copy link

🚀 PR was released in v1.0.0 🚀

@yarikoptic yarikoptic deleted the enh-compare branch December 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant