Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create_seqinfo tiny bit to avoid duplication and add logging; and in tests to reuse list of dicom paths #785

Merged
merged 5 commits into from
Oct 1, 2024

Commits on Sep 16, 2024

  1. RF: Gather/use list of all dicom files to avoid calling wrapper_from_…

    …file at module level
    
    I think it is safer to avoid 3rd party library calls at the module import time
    since if they are buggy it would be too loud of kaboom. Also it adds CPU time
    at import time even if not used later on. So replaced with defining a list
    of all DICOMs and then just using that function directly from filename.
    
    This also would run it against more DICOMs as this time we would glob recursively.
    yarikoptic committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2862c9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c329be View commit details
    Browse the repository at this point in the history
  3. RF: reduce duplication and log at DEBUG what was our assumption when …

    …we extracted sequence_name
    yarikoptic committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f113da1 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Add type annotations

    Co-authored-by: Basile <[email protected]>
    yarikoptic and bpinsard authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2efb747 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Configuration menu
    Copy the full SHA
    7c24da0 View commit details
    Browse the repository at this point in the history