Rename ReadOnly with Training

nlpodyssey · Jan 22, 2021 · 3906c42 · 3906c42
1 parent fdef275
commit 3906c42
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/pkg/nlp/transformers/bert/bert.go b/pkg/nlp/transformers/bert/bert.go
@@ -45,7 +45,7 @@ type Config struct {
 	TypeVocabSize         int               `json:"type_vocab_size"`
 	VocabSize             int               `json:"vocab_size"`
 	ID2Label              map[string]string `json:"id2label"`
-	ReadOnly              bool              `json:"read_only"`
+	Training              bool              `json:"training"` // Custom for spaGO
 }
 
 func init() {
@@ -93,7 +93,7 @@ func NewDefaultBERT(config Config, embeddingsStoragePath string) *Model {
 			MaxPositions:        config.MaxPositionEmbeddings,
 			TokenTypes:          config.TypeVocabSize,
 			WordsMapFilename:    embeddingsStoragePath,
-			WordsMapReadOnly:    config.ReadOnly,
+			WordsMapReadOnly:    !config.Training,
 			DeletePreEmbeddings: false,
 		}),
 		Encoder: NewBertEncoder(EncoderConfig{

diff --git a/pkg/nlp/transformers/bert/converter.go b/pkg/nlp/transformers/bert/converter.go
@@ -46,6 +46,9 @@ func ConvertHuggingFacePreTrained(modelPath string) error {
 	if err != nil {
 		return err
 	}
+	// Enable training mode, so that we have writing permissions
+	// (for example, for embeddings storage files).
+	config.Training = true
 	vocab, err := vocabulary.NewFromFile(vocabFilename)
 	if err != nil {
 		return err