Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test for LogicMonitor historical_data_retrieval #303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcinlawnik
Copy link
Contributor

@marcinlawnik marcinlawnik commented Sep 5, 2024

Motivation

#292 introduced Logic Monitor Historical Data Retrieval, but it was not reflected in tests.
Test was added for GCM direct.

Summary

Added test

Related Changes

#292

Testing

  • No manual testing needed, automated test coverage extended.

@n9-machine-user n9-machine-user added the go Pull requests that update Go code label Sep 5, 2024
@marcinlawnik marcinlawnik changed the title testL Add test for newly added feature that was missed in previous PR testL Add test for LogicMonitor historical_data_retrieval Sep 5, 2024
@marcinlawnik marcinlawnik changed the title testL Add test for LogicMonitor historical_data_retrieval test: Add test for LogicMonitor historical_data_retrieval Sep 5, 2024
@marcinlawnik
Copy link
Contributor Author

cc: @mkaras-nobl9 for when you're back from vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants