Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add loongson-clfs-loongarch64-{1,2,3} (#3740) #3741

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shipujin
Copy link
Member

ansible: add loongson-clfs-loongarch64-{1,2,3} (#3740)

Refs: #3740

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, @richardlau could you take a look as well?

@shipujin
Copy link
Member Author

In order to facilitate the management of the machine network, the network IP is adjusted, thank you

Best regards

@mhdawson
Copy link
Member

@shipujin I tried to ssh into the two new machines and it just seems to hang ?

@shipujin
Copy link
Member Author

@shipujin I tried to ssh into the two new machines and it just seems to hang ?

Sorry, I re-updated the port, please try again, thank you

Best regards

@mhdawson
Copy link
Member

@shipujin thanks, I can log in with the updated ports.

@shipujin I assume that it will appear that connections from the machines will all come from the same ip, if so I don't think any additions will be needed to the firewall rules.

I'll try to look at adding them to Jenkins tomorrow.

@shipujin
Copy link
Member Author

@shipujin thanks, I can log in with the updated ports.

ok

@shipujin I assume that it will appear that connections from the machines will all come from the same ip, if so I don't think any additions will be needed to the firewall rules.

Yes, now that the firewall content has been removed, there are no whitelist rules

I'll try to look at adding them to Jenkins tomorrow.

Okay, thank you for your help. Thank you

Best regards

@mhdawson
Copy link
Member

@shipujin have you run the ansible playbooks on the new hosts? I went to see if

./systemd/system/jenkins.service

existed so that I could create the host in jenkins and add the secret to that file, but it does not seem to be there on the 2nd machine when I logged in. I think that should have been created with the ansible scripts but not populated with the secret.

@mhdawson
Copy link
Member

It's likelyl we manually installed the jenkins service on the first machine, but we should have ansible configuring as much as possible as we roll out newer machines so hoping the PR to add the ansible configration would be covering that.

@shipujin
Copy link
Member Author

existed so that I could create the host in jenkins and add the secret to that file, but it does not seem to be there on the 2nd machine when I logged in. I think that should have been created with the ansible scripts but not populated with the secret.

I am studying nodejs/build project today, I don't know how the new machine generates "secret", I may have to continue to study nodejs/build project

Best regards

@shipujin
Copy link
Member Author

Resolve conflicting files

@shipujin
Copy link
Member Author

shipujin commented May 31, 2024

It's likelyl we manually installed the jenkins service on the first machine, but we should have ansible configuring as much as possible as we roll out newer machines so hoping the PR to add the ansible configration would be covering that.

I am studying nodejs/build project today, I don't know how the new machine generates "secret", I may have to continue to study nodejs/build project.

Is it how to generate "secret", is it generated by which tool of the "nodejs/build" project, thx~

Best regards

@mhdawson
Copy link
Member

mhdawson commented Jun 3, 2024

It's ok if the ansible run does not install the right secret as that is not available until I create the machines in Jenkins. What I was hoping was that the ansible setup would create the ./systemd/system/jenkins.service. I could then ust update it once I create the machine with the right secret.

@shipujin
Copy link
Member Author

shipujin commented Jun 5, 2024

What I was hoping was that the ansible setup would create the ./systemd/system/jenkins.service.

I added support for clfs-loongarch64 to the ansible/roles/jenkins-worker/vars/main.yml file, What command of ansible should I execute on the two new machines to verify my nodejs/build changes? Sorry, I don't know how to use 'ansible' on 'nodejs/build'

Best regards

diff --git a/ansible/roles/jenkins-worker/vars/main.yml b/ansible/roles/jenkins-worker/vars/main.yml                                                                                      
index 544c0ef..b5979b6 100644
--- a/ansible/roles/jenkins-worker/vars/main.yml
+++ b/ansible/roles/jenkins-worker/vars/main.yml
@@ -9,7 +9,7 @@ init: {
   freebsd: 'freebsd',
   ibmi: 'ibmi73',
   macos: 'macos',
-  systemd: ['centos7', 'debian', 'fedora', 'rhel7', 'rhel8', 'rhel9', 'ubuntu1604', 'ubuntu1804','ubuntu2204'],                                                                          
+  systemd: ['centos7', 'clfs', 'debian', 'fedora', 'rhel7', 'rhel8', 'rhel9', 'ubuntu1604', 'ubuntu1804','ubuntu2204'],                                                                  
   svc: 'smartos',
   zos_start: 'zos'
   }
@@ -61,6 +61,7 @@ jenkins: "{{ jenkins_init[init_type] }}"

 # some os'es needs different paths to java. add them here.
 java_path: {
+  'clfs': '/opt/jdk17/bin/java',
   'ibmi73': '/QOpenSys/pkgs/lib/jvm/openjdk-11/bin/java',
   'macos10.15': 'java',
   'macos11': 'java',

@mhdawson
Copy link
Member

mhdawson commented Jun 6, 2024

@shipujin these are the getting started instructions for using the Node.js ansible scripts - https://github.com/nodejs/build/tree/main/ansible#getting-started

@shipujin
Copy link
Member Author

@shipujin these are the getting started instructions for using the Node.js ansible scripts - https://github.com/nodejs/build/tree/main/ansible#getting-started

Okay, I'm learning this

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants