cli: add --audit and --auditList options #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `citgm-all --auditList` option which will list all modules that are flaky or skipped on current machine, including the the matched reason: "version", "distro", "release", "platform", "endian" or "fips". Running `citgm-all --auditList reson1 reasn2...` will show only the modules that are skipped or flaky because they match given reason. Calling `citgm-all --audit` will run the smoke tests for all modules that are skipped or flaky. Tested modules can also be filtered by providing list of "reasons" to test.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Should we close this? |
|
I think we should land this, but I didn't have time recently to write tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short: on Windows running
citgm-all --auditList platformwill list all modules that are flaky/skipped on win32. Runningcitgm-all --audit platformwill run the smoke tests for all the skipped/flaky modules.Adds
citgm-all --auditListoption which will list all modules that are flaky or skipped on current machine, including the the reason a module is skipped:Running
citgm-all --auditList reson1 reasn2...will show only the modules that are skipped or flaky because they match given reason.Calling
citgm-all --auditwill run the smoke tests for all modules that are skipped or flaky. Tested modules can also be filtered by providing list of "reasons" to test.Checklist
npm testpassesThe test for current master do not pass neither on my WSL installation nor on my Win10 box. I've added some tests, I'll add more when I get
test\bin\test-citgm-all.jswork on Windows.