Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: http caching #3562

Merged
merged 65 commits into from
Oct 14, 2024
Merged

feat: http caching #3562

merged 65 commits into from
Oct 14, 2024

Commits on Sep 14, 2024

  1. feat: http caching 

    Implements bare-bones http caching as per rfc9111

Closes nodejs#3231
Closes nodejs#2760
Closes nodejs#2256
Closes nodejs#1146

Co-authored-by: Carlos Fuentes <[email protected]>

Co-authored-by: Robert Nagy <[email protected]>

Co-authored-by: Isak Törnros <[email protected]>

Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    f69a8b2 View commit details
    Browse the repository at this point in the history

  2. fixup! feat: http caching 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    57c0f45 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. fixup! fixup! feat: http caching 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    c88fb25 View commit details
    Browse the repository at this point in the history

  2. fixup! fixup! fixup! feat: http caching 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    0a442b2 View commit details
    Browse the repository at this point in the history

  3. Update lib/handler/cache-handler.js 

    Co-authored-by: Robert Nagy <[email protected]>
    @flakey5 @ronag
    flakey5 and ronag authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    ae6edca View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Carlos Fuentes <[email protected]>
    @flakey5 @metcoder95
    flakey5 and metcoder95 authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    26b2227 View commit details
    Browse the repository at this point in the history

  2. fixup! fixup! fixup! fixup! feat: http caching 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    81cb021 View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! fixup! fixup! fixup! feat: http caching 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6bff376 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. clarify type for MemoryCacheStore 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2edee29 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f128e9a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    807e764 View commit details
    Browse the repository at this point in the history

  4. tmp 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4f8139a View commit details
    Browse the repository at this point in the history

  5. fixup! tmp 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fabf558 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4546799 View commit details
    Browse the repository at this point in the history

  2. perf things, deleteByOrigin 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5a215d2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. incredibly messy and broken impl of streaming idea 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    73564e8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into flakey5/3231

    @metcoder95
    metcoder95 authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3a08528 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. fix tests 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    cbe7b97 View commit details
    Browse the repository at this point in the history

  2. check if the response is already cached again 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    edc0772 View commit details
    Browse the repository at this point in the history

  3. backpressure patch 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    d7b24a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. move body out of CacheStoreValue, remove size property 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0877f95 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Robert Nagy <[email protected]>
    @flakey5 @ronag
    flakey5 and ronag authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e065a8e View commit details
    Browse the repository at this point in the history

  2. add some comments on createWriteStream 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    230533a View commit details
    Browse the repository at this point in the history

  3. fix type tests, make staleAt and deleteAt absolute 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bcd7fa1 View commit details
    Browse the repository at this point in the history

  4. empty the body when overwriting the response 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9ef03ef View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into flakey5/3231

    @metcoder95
    metcoder95 authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    85a99d5 View commit details
    Browse the repository at this point in the history

  6. update onError calls 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    58839ee View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. remove request deduplication for now 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e49a32c View commit details
    Browse the repository at this point in the history

  2. rename value -> opts, storedValue -> value 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6469aab View commit details
    Browse the repository at this point in the history

  3. fix types 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    969deb2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Matteo Collina <[email protected]>
    @flakey5 @mcollina
    flakey5 and mcollina authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3370f66 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. simplify parsing for qualified no-cache and private 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    263718e View commit details
    Browse the repository at this point in the history

  2. fix header omission, some cleanup 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    b5e483a View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Merge branch 'main' into flakey5/3231 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    7ea49d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'main' into flakey5/3231

    @metcoder95
    metcoder95 authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ded27a1 View commit details
    Browse the repository at this point in the history

  2. running the tests in ci is probably a good idea 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d983b9c View commit details
    Browse the repository at this point in the history

  3. fix some testing values 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6b1de1f View commit details
    Browse the repository at this point in the history

  4. fixup! running the tests in ci is probably a good idea 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    7e482e9 View commit details
    Browse the repository at this point in the history

  5. Update lib/interceptor/cache.js 

    Co-authored-by: Robert Nagy <[email protected]>
    @flakey5 @ronag
    flakey5 and ronag authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e433ec6 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Update lib/util/cache.js 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d8c7368 View commit details
    Browse the repository at this point in the history

  2. update from reviews 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0a7a99e View commit details
    Browse the repository at this point in the history

  3. Update lib/interceptor/cache.js 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    43efed2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Robert Nagy <[email protected]>
    @flakey5 @ronag
    flakey5 and ronag authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e765976 View commit details
    Browse the repository at this point in the history

  5. change from reviews 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    019f9b4 View commit details
    Browse the repository at this point in the history

  6. add promise support back for createReadStream 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1db72bb View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Robert Nagy <[email protected]>
    @flakey5 @ronag
    flakey5 and ronag authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ab72d14 View commit details
    Browse the repository at this point in the history

  2. check if onError was called 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    917b530 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. add docs 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2adae09 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into flakey5/3231

    @flakey5
    flakey5 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0ed33e4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into flakey5/3231

    @metcoder95
    metcoder95 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b951bd5 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. add errorCallback 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    eda939d View commit details
    Browse the repository at this point in the history

  2. Update types/cache-interceptor.d.ts 

    Co-authored-by: Carlos Fuentes <[email protected]>
    @flakey5 @metcoder95
    flakey5 and metcoder95 authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a43112a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. use fake timers and cleanup client 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    684d044 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. lazy cache wellknown headers 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    12c2ded View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Merge branch 'main' into flakey5/3231

    @metcoder95
    metcoder95 authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    af0875e View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    29b1362 View commit details
    Browse the repository at this point in the history

  2. Update lib/cache/memory-cache-store.js 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9e4f15b View commit details
    Browse the repository at this point in the history

  3. code review 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a5a3cf3 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8bf9864 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Aras Abbasi <[email protected]>
    @flakey5 @Uzlopak
    flakey5 and Uzlopak authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    baaa914 View commit details
    Browse the repository at this point in the history

  6. code review pt2 

    Signed-off-by: flakey5 <[email protected]>
    @flakey5
    flakey5 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8bf6b42 View commit details
    Browse the repository at this point in the history

  7. Update lib/handler/cache-revalidation-handler.js 

    Co-authored-by: Aras Abbasi <[email protected]>
    @mcollina @Uzlopak
    mcollina and Uzlopak authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    05109b1 View commit details
    Browse the repository at this point in the history

  8. Update lib/handler/cache-handler.js 

    Co-authored-by: Aras Abbasi <[email protected]>
    @mcollina @Uzlopak
    mcollina and Uzlopak authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    092d9d4 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review

    @Uzlopak
    Uzlopak authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1b91475 View commit details
    Browse the repository at this point in the history

  10. fix

    @Uzlopak
    Uzlopak committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e6aeda9 View commit details
    Browse the repository at this point in the history