[ feat ] Header 컴포넌트 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeuna
requested changes
Jul 9, 2022
components/common/Header.tsx
Outdated
| <StMenuBtn type="button" onClick={() => router.push('/toyView')}> | ||
| 상품보기 | ||
| </StMenuBtn> | ||
| <StMenuBtn type="button" onClick={() => router.push('/community')}> |
There was a problem hiding this comment.
#1 이슈보면 하단 리뷰에
링크 이동은 next js 에서 제공하는 Link 태그가 더 SEO에 최적화된다고 알고 있습니다 !!
라는 리뷰가 있어요! 그래서, 새탭열지 않고 우리 페이지들 중에서 링크 전환하는 거면 Link태그 사용하면 좋을 것 같습니다!
components/common/Header.tsx
Outdated
| <IcNoriHeaderLogo type="button" onClick={() => router.push('/')} /> | ||
| <StSearchWrapper> | ||
| <StSearchBar> | ||
| <input placeholder="상품명, 스토어명을 검색해보세요!" /> |
components/common/Header.tsx
Outdated
|
|
||
| width: 100%; | ||
| height: 11.4rem; | ||
|
|
||
| background-color: #31cc94; | ||
| color: #ffffff; | ||
| `; | ||
|
|
There was a problem hiding this comment.
우리 컨벤션에서 스타일드 컴포넌트 사이에는 띄어쓰기 안 하는걸로 했어용!
Happhee
reviewed
Jul 9, 2022
components/common/Header.tsx
Outdated
| </p> | ||
| </StTopLink> | ||
| <StHeaderContents> | ||
| <IcNoriHeaderLogo type="button" onClick={() => router.push('/')} /> |
There was a problem hiding this comment.
음 일단은 버튼 기능을 해서 지정은 해 뒀는데 굳이 할 필요 없으려나??
|
뀻~~~ 이래저래 정신없을텐데 고생했어욥 리뷰 달려고 보니까 다른 친구들이 야무지게 달아줬네 굿굿 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issues
🎡 작업 내용
✅ PR Point
😡 Trouble Shooting
밑 스크린샷 보면 GlobalStyle 로 폰트가 지정되어 있을텐데,
pretandard 로 폰트를 지정해준 placeholder를 제외하고 폰트가 적용되지 않는 모습을 보입니다. PR 올린 후에 develop 에서 수정된 부분 확인해보겠습니다.
PR 올린 후 스타일 초기 세팅대로 수정토록 하겠습니다!
👀 스크린샷 / GIF / 링크
input에 focus 되었을 때