Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom-layouts.md #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update custom-layouts.md #374

wants to merge 1 commit into from

Conversation

seneca
Copy link
Contributor

@seneca seneca commented Sep 24, 2024

In the picture above the blue box containing aside, page head, page foot and beside is not named. Shouldn't it be named main?

The main blue box containing aside, page head, page foot and beside is not named. Shouldn't it be named main?
@nobkd
Copy link
Collaborator

nobkd commented Sep 25, 2024

If you mean this image, I agree, that the main area should be named main (or with the slot name? See #369 (comment))


from here: https://nuejs.org/docs/custom-layouts.html

@tomByrer
Copy link

tomByrer commented Oct 1, 2024

@nobkd is the right hand side label beside a typo?
Seems it also should be aside, or maybe aside @complementary?
https://github.com/nuejs/nue/blob/master/packages/nuejs.org/docs/layout.html#L16

@nobkd
Copy link
Collaborator

nobkd commented Oct 1, 2024

No, iirc it isn't. All bold values are html elements (with slot I think), all non-bold ones are @name="<component>" layout components, you can define in your layout component files (maybe it can even be a non-layout component, but I'm not sure, as I haven't tested that one)
For the components, you can decide, what the html element is, yourself

You can see an usage example for pagefoot in #373

@tipiirai
Copy link
Contributor

tipiirai commented Oct 3, 2024

I'm doing a significant update to the documentation. Make it much clearer and the product should feel much less "magical". Here is a new picture for this specific topic I'm going to use

@nobkd
Copy link
Collaborator

nobkd commented Oct 3, 2024

Wasn't <footer> something different from @name="pagefoot"?
Imo it makes sense to have a footer element at the bottom of the page, not inside the main at all, but e.g. where you put @bottom in your graphic. Maybe even just replacing it.
I'd have to recheck how it is semantically, where you put the footer element, but I always thought, you should use one footer, at the end of the page, not inside main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants