Move "Attributes" and "Methods" below "Parameters"

[lucascolley]

Reorder the sections in docscrape to match the style guide. As per https://numpydoc.readthedocs.io/en/latest/format.html#class-docstring, the Attributes section should be "located below the Parameters section", which I am interpreting as directly below. It seems wrong for Attributes to be below Notes, References and Examples.

x-ref scipy/scipy#21099

[larsoner]

@lucascolley can you look to see if there is some test that could be added or modified that would have caught this?

[lucascolley]

this test

numpydoc/numpydoc/tests/test_docscrape.py

Line 1258 in 54dbc89

def test_class_members_doc_sphinx():

actually expects Examples to be above Attributes and Methods. So maybe the question of where they should go isn't settled. I think that we should either change the order in the code/tests (my preference - I don't see why See Also should be above Attributes, for example), or change the wording in the style guide.

[lucascolley]

I opened gh-572 in case we need higher-level discussion.

[rossbar]

FWIW I'm in favor of the change - class attributes and methods are typically key pieces of API, so ensuring that they render near the top of the docstring instead of being buried under the other sections seems like an improvement.

[lucascolley]

could someone approve CI please? :)

[larsoner]

Done!

[lucascolley]

apologies for the iteration, I was being lazy and not running the tests - they all pass locally for me now!

[larsoner]

Seems like everyone is in favor so in it goes, thanks @lucascolley !

[lucascolley]

thanks all!