Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simpleFlake #108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update simpleFlake #108

wants to merge 2 commits into from

Conversation

xiaoyuechen
Copy link

Change deprecated attributes defaultPackage and devShell.default to packages.default and devShells.default.

Remove deprecated attributes defaultPackage and devShell.default
simpleFlake.nix Show resolved Hide resolved
Comment on lines -76 to -77
} else if packages ? devShell then {
devShell = packages.devShell;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also for back-compat? From nix3-develop manual:

Flake output attributes
If no flake output attribute is given, nix develop tries the following
flake output attributes:

   •  devShells.<system>.default

   •  packages.<system>.default

@xiaoyuechen
Copy link
Author

I also have a question on legacyPackages = packages;. The comment says it's more forgiving, I don't why that is the case. Can we just inherit packages;?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants