Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore if-modifided-since and if-none-match proxy headers #558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Ignore if-modifided-since and if-none-match proxy headers #558

wants to merge 1 commit into from

Conversation

davision
Copy link

Fixes #557

@davision davision changed the title fix: Ignore if-modifided-since and if-none-match proxy headers #557 fix: Ignore if-modifided-since and if-none-match proxy headers Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #558 (1115fb1) into main (a99b56c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files           1        1           
  Lines          53       53           
  Branches       29       29           
=======================================
  Hits           47       47           
  Misses          6        6
Impacted Files Coverage Δ
lib/module.js 88.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a99b56c...1115fb1. Read the comment docs.

fago
fago approved these changes Jan 13, 2022
View reviewed changes
Copy link

@fago fago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it should. see #557 for the reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vloss3 vloss3 vloss3 approved these changes

@christophheich christophheich christophheich approved these changes

@fago fago fago approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If-modified-since and If-none-match headers may break Nuxt when using axios
4 participants
@davision @fago @christophheich @vloss3