Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow disabling vite hmr port integration #189

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 14, 2023

Followup on #184

Since this is a new feature, there might be conditions we might want to disable hmr port integration. Also seems bun has some issues which we might need to disable for bun for now.

This PR allows disabling the effect of #184 using NUXI_DISABLE_VITE_HMR env. It is not a flag since probably won't last long.

@pi0 pi0 marked this pull request as ready for review September 14, 2023 18:03
@pi0 pi0 merged commit b31c3d5 into main Sep 14, 2023
2 checks passed
@pi0 pi0 deleted the chore/disable-vite-hmr branch September 14, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant