fix: nuxtpicture placeholder #1396
Open
+209
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawid-napora
approved these changes
Aug 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
+ Coverage 62.20% 62.44% +0.23%
==========================================
Files 79 79
Lines 3593 3605 +12
Branches 391 401 +10
==========================================
+ Hits 2235 2251 +16
+ Misses 1328 1324 -4
Partials 30 30 ☔ View full report in Codecov by Sentry. |
danielroe
reviewed
Aug 27, 2024
Comment on lines
+138
to
+140
| if (mainSrc.value.sizes) img.sizes = mainSrc.value.sizes | ||
| if (mainSrc.value.srcset) img.srcset = mainSrc.value.srcset | ||
| if (mainSrc.value.src) img.src = mainSrc.value.src |
There was a problem hiding this comment.
I'm a bit worried that we end up loading more images than necessary. So, mainSrc will load, but then if there is another src that better suits browser needs (e.g. avif/webp), this will swap in, and we will have downloaded twice as much image data as we need.
do you have any ideas for resolving that? maybe using a picture element as placeholder instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1160.
Adds placeholder behavior to NuxtPicture by initially setting the img element's src tag to the placeholder, waiting for the main src to load, and then showing the image.