Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nuxt-inline-scripts #1059

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add nuxt-inline-scripts #1059

wants to merge 4 commits into from

Conversation

Dante-dan
Copy link

related nuxt/nuxt#27004

🔗 Linked issue

related nuxt/nuxt#27004

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Use link-scripts instead of inline-scirpts to avoid some browser security policies

danielroe
danielroe reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can probably remove the .png file as it's not used in this PR

@Dante-dan
Copy link
Author

‌‌‌‌‌Thank you for your suggestion, I have deleted the unnecessary files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dante-dan @danielroe